popup menu for multi-reference bookmark navigation (#crossref)#1335
Conversation
Add a user-controlled option for navigating multi-reference bookmarks: - When a bookmark key contains multiple references (semicolons, commas, or verse ranges), the user can choose between two behaviours via a new 'Open cross-references in a popup menu' toggle in the bookmark context menu. - When enabled (checked): a popup menu lists each reference individually; clicking one navigates directly to that verse. Verse ranges (e.g. Mt 15:1-9) are displayed with their full label but navigate to the first verse of the range. - When disabled (unchecked): the full key is passed to main_url_handler which displays all references in the Verse List as before. - Single references and studypad bookmarks are unaffected. - The preference is saved to and restored from the Xiphos config file under misc/crossref_popup (default: 0 = verse list behaviour).
|
This seemed good. I will make one adjustment to provide for initialization in xml.c. |
|
Oh no. I did this too soon. Glitch. Big glitch. This is what the same verse dump looks like in the popup. If I click the entry for Acts 8:36, being fully specified, it goes there correctly. The problem is that incomplete specification is handled properly when the verse list is processed by Sword. ...works fine when processed by Sword because it contextually fills in the fact that e.g. "18:10" is part of a Matthew citation. So it fills that in when returning the list of individual verses. The popup handling does not provide for this. It leaves the partial (but proper and normal) specification as partial, leaving it contextually unanchored when referenced alone. I don't want to revert this because the concept is fine, especially being user-selectable so the old behavior is default. But it very badly needs a fix to pass the verse list through Sword for contextual resolution. |
|
Ok this week I'm busy busy!! Next week I will look at this. |
|
No sweat. The sole problem is that you still need to pass the bookmark's verse list through Sword just as is done when preparing the verse list dump in the default no-popup case. |
|
In the end, Claude solved it for me in 15 minutes! I hope that's okay, but take a look at the screenshot—it seems to match the bookmarks you gave me. |
2 participants
Add a user-controlled option for navigating multi-reference bookmarks:
When a bookmark key contains multiple references (semicolons, commas, or verse ranges), the user can choose between two behaviours via a new 'Open cross-references in a popup menu' toggle in the bookmark context menu.
When enabled (checked): a popup menu lists each reference individually; clicking one navigates directly to that verse. Verse ranges (e.g. Mt 15:1-9) are displayed with their full label but navigate to the first verse of the range.
When disabled (unchecked): the full key is passed to main_url_handler which displays all references in the Verse List as before.
Single references and studypad bookmarks are unaffected.
The preference is saved to and restored from the Xiphos config file under misc/crossref_popup (default: 0 = verse list behaviour).